Krazy2 Analysis of graphics/digikam (Revision = master-rev-5fce4d5bca)

Checksets = kde5,foss
Checkers Run = 54
Files Processed = 4487
Total Issues = 500 ...as of January 08 2025 05:22:18 UTC

• For File Type messages
  1. Check for appending to rc.cpp [rcappend]...okay!
• For File Type cmake
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check for problems with filenames [filenames]...okay!
  3. Check for URLs not using transport encryption [insecurenet]...okay!
  4. Check for spelling errors [spelling]...okay!
• For File Type c++
  1. Check for methods that return 'const' refs in public classes [constref]...okay!
  2. Check for an acceptable copyright [copyright]...okay!
  3. Check for cpp macros and usage [cpp]...okay!
  4. Check for code that should be considered crashy. [crashy]...okay!
  5. Check single-char QString operations for efficiency [doublequote_chars]...okay!
  6. Check for unwanted doxygen tags in major versions [doxytags]...okay!
  7. Check public classes with private members or d-pointer issues [dpointer]...okay!
  8. Check for QString compares to "" [emptystrcompare]...okay!
  9. Check that file ends with a newline [endswithnewline]...okay!
  10. Check for C++ ctors that should be declared 'explicit' [explicit]...okay!
  11. Check for problems with filenames [filenames]...okay!
  12. Check validity of i18n calls [i18ncheckarg]...OOPS! 488 issues found!
      • /mnt/data/Devel/8.x/core/showfoto/main/main.cpp: missing KUIT context marker line# 211,212,220 (3)
      • /mnt/data/Devel/8.x/core/showfoto/main/showfoto_open.cpp: missing KUIT context marker line# 303,326 (2)
      • /mnt/data/Devel/8.x/core/utilities/searchwindow/searchmodificationhelper.cpp: missing KUIT context marker line# 72,109,142 (3)
      • /mnt/data/Devel/8.x/core/utilities/setup/setupgeolocation.cpp: missing KUIT context marker line# 104,132 (2)
      • /mnt/data/Devel/8.x/core/utilities/setup/setupgeolocation.cpp: HTML tag 'a' is not advised with KUIT markup line# 115 (1)
      • /mnt/data/Devel/8.x/core/utilities/setup/setupdatabase.cpp: HTML tag 'b' is not advised with KUIT markup line# 197 (1)
      • /mnt/data/Devel/8.x/core/utilities/setup/collections/setupcollectionview.cpp: missing KUIT context marker line# 634,702,866,874,939,944,949,986,1036,1132,1137,1142,1161,1189,1217,1252,1257,1262,1560,1632,1636,1723,1729,1730,1731 (25)
      • /mnt/data/Devel/8.x/core/utilities/geolocation/geoiface/core/geopluginaboutdlg.cpp: missing KUIT context marker line# 96 (1)
      • /mnt/data/Devel/8.x/core/utilities/geolocation/geoiface/core/geopluginaboutdlg.cpp: HTML tag 'p' is not advised with KUIT markup line# 96 (1)
      • /mnt/data/Devel/8.x/core/utilities/geolocation/geoiface/backends/mapbackend.cpp: missing KUIT context marker line# 58,68,149,162,178 (5)
      • /mnt/data/Devel/8.x/core/utilities/geolocation/geoiface/bookmark/bookmarksdlg.cpp: missing KUIT context marker line# 92,99,104,223,226,370,429 (7)
      • /mnt/data/Devel/8.x/core/utilities/geolocation/geoiface/bookmark/bookmarksmngr.cpp: missing KUIT context marker line# 46,88,134,141,148,813,936,948,955,962,963,973 (12)
      • /mnt/data/Devel/8.x/core/utilities/maintenance/main/maintenancedlg.cpp: HTML tag 'qt' is not advised with KUIT markup line# 48,72,85 (3)
      • /mnt/data/Devel/8.x/core/utilities/maintenance/main/maintenancedlg.cpp: HTML tag 'br' is not advised with KUIT markup line# 72,85 (2)
      • /mnt/data/Devel/8.x/core/utilities/maintenance/main/maintenancedlg.cpp: HTML tag 'p' is not advised with KUIT markup line# 236,236,253,253,266,266,266 (7)
      • /mnt/data/Devel/8.x/core/utilities/maintenance/main/maintenancedlg.cpp: HTML tag 'i' is not advised with KUIT markup line# 72,85 (2)
      • /mnt/data/Devel/8.x/core/utilities/maintenance/main/maintenancedlg.cpp: HTML tag 'b' is not advised with KUIT markup line# 48,236,253,253,266,266,266 (7)
      • /mnt/data/Devel/8.x/core/utilities/maintenance/main/maintenancedlg.cpp: missing KUIT context marker line# 48,63,72,75,85,90,91,92,93,94,101,110,116,125,131,144,164,168,169,170,187,198,225,246,251,252,258,263,264,265,285,296,301,302,310,321,325,326,329,332,338,400 (42)
      • /mnt/data/Devel/8.x/core/utilities/facemanagement/dialogs/recognitionmodelchange.cpp: missing KUIT context marker line# 76,82,110,114 (4)
      • /mnt/data/Devel/8.x/core/utilities/facemanagement/widgets/facescanwidget.cpp: HTML tag 'p' is not advised with KUIT markup line# 294,294,294,294 (4)
      • /mnt/data/Devel/8.x/core/utilities/facemanagement/widgets/facescanwidget.cpp: HTML tag 'b' is not advised with KUIT markup line# 294,294,294,294,294,294,294 (7)
      • /mnt/data/Devel/8.x/core/utilities/facemanagement/widgets/facescanwidget.cpp: missing KUIT context marker line# 323,393 (2)
      • /mnt/data/Devel/8.x/core/utilities/queuemanager/views/workflowdlg.cpp: HTML tag 'qt' is not advised with KUIT markup line# 74,78 (2)
      • /mnt/data/Devel/8.x/core/utilities/queuemanager/views/workflowdlg.cpp: missing KUIT context marker line# 74,78,101,130 (4)
      • /mnt/data/Devel/8.x/core/utilities/queuemanager/views/workflowdlg.cpp: HTML tag 'b' is not advised with KUIT markup line# 74,78 (2)
      • /mnt/data/Devel/8.x/core/utilities/imageeditor/main/imagewindow.cpp: HTML tag 'qt' is not advised with KUIT markup line# 1223 (1)
      • /mnt/data/Devel/8.x/core/utilities/imageeditor/main/imagewindow.cpp: missing KUIT context marker line# 200,204,375,504,588,703,949,1120,1145,1177 (10)
      • /mnt/data/Devel/8.x/core/utilities/imageeditor/main/imagewindow.cpp: HTML tag 'b' is not advised with KUIT markup line# 1223 (1)
      • /mnt/data/Devel/8.x/core/utilities/advancedrename/advancedrenameprocessdialog.cpp: missing KUIT context marker line# 67,82,158,218 (4)
      • /mnt/data/Devel/8.x/core/utilities/advancedrename/advancedrenameprocessdialog.cpp: HTML tag 'b' is not advised with KUIT markup line# 67,218 (2)
      • /mnt/data/Devel/8.x/core/utilities/import/widgets/albumcustomizer.cpp: HTML tag 'b' is not advised with KUIT markup line# 76,76,76,76,76,76,76,76,76,76,76,76,76 (13)
      • /mnt/data/Devel/8.x/core/utilities/import/widgets/albumcustomizer.cpp: HTML tag 'p' is not advised with KUIT markup line# 76,76,76,76,76,76,76,76,76,76,76,76,76,76,76 (15)
      • /mnt/data/Devel/8.x/core/utilities/import/widgets/freespacewidget.cpp: missing KUIT context marker line# 301 (1)
      • /mnt/data/Devel/8.x/core/app/main/digikamapp_import.cpp: HTML tag 'p' is not advised with KUIT markup line# 157 (1)
      • /mnt/data/Devel/8.x/core/app/main/digikamapp_import.cpp: missing KUIT context marker line# 157,186 (2)
      • /mnt/data/Devel/8.x/core/app/items/utils/itemviewutilities.cpp: HTML tag 'p' is not advised with KUIT markup line# 228 (1)
      • /mnt/data/Devel/8.x/core/app/items/utils/itemviewutilities.cpp: missing KUIT context marker line# 228,353 (2)
      • /mnt/data/Devel/8.x/core/app/views/utils/componentsinfodlg.cpp: missing KUIT context marker line# 231,248,268,285,303 (5)
      • /mnt/data/Devel/8.x/core/libs/tags/autoassignment/autotagsscanwidget.cpp: HTML tag 'p' is not advised with KUIT markup line# 82,82,99,99,112,112,112 (7)
      • /mnt/data/Devel/8.x/core/libs/tags/autoassignment/autotagsscanwidget.cpp: missing KUIT context marker line# 92,97,98,104,109,110,111 (7)
      • /mnt/data/Devel/8.x/core/libs/tags/autoassignment/autotagsscanwidget.cpp: HTML tag 'b' is not advised with KUIT markup line# 82,99,99,112,112,112 (6)
      • /mnt/data/Devel/8.x/core/libs/properties/captions/itemdescedittab.cpp: HTML tag 'li' is not advised with KUIT markup line# 328,333,338,343,348,353,358 (7)
      • /mnt/data/Devel/8.x/core/libs/properties/captions/itemdescedittab.cpp: HTML tag 'p' is not advised with KUIT markup line# 320,320,363 (3)
      • /mnt/data/Devel/8.x/core/libs/dialogs/libsinfodlg.cpp: missing KUIT context marker line# 547,553,628 (3)
      • /mnt/data/Devel/8.x/core/libs/dialogs/rawcameradlg.cpp: missing KUIT context marker line# 125,135 (2)
      • /mnt/data/Devel/8.x/core/libs/dialogs/rawcameradlg.cpp: HTML tag 'br' is not advised with KUIT markup line# 125,125,135,135 (4)
      • /mnt/data/Devel/8.x/core/libs/dialogs/infodlg.cpp: HTML tag 'br' is not advised with KUIT markup line# 90 (1)
      • /mnt/data/Devel/8.x/core/libs/dialogs/infodlg.cpp: HTML tag 'font' is not advised with KUIT markup line# 90 (1)
      • /mnt/data/Devel/8.x/core/libs/dialogs/infodlg.cpp: missing KUIT context marker line# 68,90,111 (3)
      • /mnt/data/Devel/8.x/core/libs/dialogs/infodlg.cpp: HTML tag 'b' is not advised with KUIT markup line# 90 (1)
      • /mnt/data/Devel/8.x/core/libs/dialogs/infodlg.cpp: HTML tag 'p' is not advised with KUIT markup line# 90,90 (2)
      • /mnt/data/Devel/8.x/core/libs/dialogs/infodlg.cpp: HTML tag 'i' is not advised with KUIT markup line# 90 (1)
      • /mnt/data/Devel/8.x/core/libs/imgqsort/imagequalityconfselector.cpp: missing KUIT context marker line# 71 (1)
      • /mnt/data/Devel/8.x/core/libs/widgets/text/spellcheckconfig.cpp: missing KUIT context marker line# 120 (1)
      • /mnt/data/Devel/8.x/core/libs/dimg/filters/curves/curvessettings.cpp: missing KUIT context marker line# 248,269 (2)
      • /mnt/data/Devel/8.x/core/libs/threadimageio/thumb/thumbnailloadthread.cpp: missing KUIT context marker line# 170 (1)
      • /mnt/data/Devel/8.x/core/libs/album/manager/albummanager_database.cpp: HTML tag 'p' is not advised with KUIT markup line# 144,157,180,215,215,224,224,224,309,309,309,328,475,475,544,544,567,567,617,617,649,649,755 (23)
      • /mnt/data/Devel/8.x/core/libs/album/manager/albummanager_database.cpp: HTML tag 'br' is not advised with KUIT markup line# 144,309,309,328,328 (5)
      • /mnt/data/Devel/8.x/core/libs/album/manager/albummanager_database.cpp: HTML tag 'b' is not advised with KUIT markup line# 180,215,215,224,224,224,309,755 (8)
      • /mnt/data/Devel/8.x/core/libs/album/manager/albummanager_database.cpp: missing KUIT context marker line# 111,128,135,144,157,173,180,215,224,243,266,309,328,347,354,475,544,567,602,617,649,714,732,755 (24)
      • /mnt/data/Devel/8.x/core/libs/album/engine/albummodificationhelper.cpp: missing KUIT context marker line# 240,253,292 (3)
      • /mnt/data/Devel/8.x/core/libs/album/engine/albummodificationhelper.cpp: HTML tag 'p' is not advised with KUIT markup line# 240,240,253,253 (4)
      • /mnt/data/Devel/8.x/core/libs/dplugins/widgets/dplugindialog.cpp: missing KUIT context marker line# 74,75 (2)
      • /mnt/data/Devel/8.x/core/libs/dplugins/widgets/dwizarddlg.cpp: missing KUIT context marker line# 67,68 (2)
      • /mnt/data/Devel/8.x/core/libs/dplugins/webservices/wsselectuserdlg.cpp: missing KUIT context marker line# 60,82 (2)
      • /mnt/data/Devel/8.x/core/libs/dplugins/iface/dmetainfoiface.cpp: missing KUIT context marker line# 276 (1)
      • /mnt/data/Devel/8.x/core/libs/database/utils/ifaces/dio.cpp: missing KUIT context marker line# 349,871,876,882,887,892,897,902,907,912,917 (11)
      • /mnt/data/Devel/8.x/core/dplugins/generic/metadata/geolocationedit/dialog/geolocationedit.cpp: missing KUIT context marker line# 296 (1)
      • /mnt/data/Devel/8.x/core/dplugins/generic/metadata/timeadjust/timeadjustdialog.cpp: missing KUIT context marker line# 105 (1)
      • /mnt/data/Devel/8.x/core/dplugins/generic/tools/calendar/wizard/calwizard.cpp: HTML tag 'br' is not advised with KUIT markup line# 200,215,222,222,222 (5)
      • /mnt/data/Devel/8.x/core/dplugins/generic/tools/calendar/wizard/calwizard.cpp: missing KUIT context marker line# 93,98,108,119,127,200,215,222,281,293,343,353 (12)
      • /mnt/data/Devel/8.x/core/dplugins/generic/tools/jalbum/wizard/jalbumoutputpage.cpp: missing KUIT context marker line# 66,70,77 (3)
      • /mnt/data/Devel/8.x/core/dplugins/generic/tools/printcreator/wizard/advprintphotopage.cpp: missing KUIT context marker line# 496,510,951,956,1115,1347 (6)
      • /mnt/data/Devel/8.x/core/dplugins/generic/view/presentation/widgets/presentationctrlwidget.cpp: missing KUIT context marker line# 225,251 (2)
      • /mnt/data/Devel/8.x/core/dplugins/generic/view/slideshow/widgets/slidetoolbar.cpp: missing KUIT context marker line# 121,134,242,399 (4)
      • /mnt/data/Devel/8.x/core/dplugins/generic/view/slideshow/common/slideshowloader.cpp: missing KUIT context marker line# 690 (1)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/mediawiki/mediawikiwindow.cpp: missing KUIT context marker line# 297,333,354 (3)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/mediawiki/mediawikitalker.cpp: missing KUIT context marker line# 112,116,154 (3)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/filetransfer/ftimportwindow.cpp: missing KUIT context marker line# 135 (1)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/filetransfer/ftimportwidget.cpp: missing KUIT context marker line# 51,62,96 (3)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/filetransfer/ftexportwindow.cpp: missing KUIT context marker line# 181 (1)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/smugmug/smugwindow.cpp: missing KUIT context marker line# 429,438,476,509,513,658,747,750,783,786,869,883,908,975,988,1008 (16)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/google/gdrive/gdtalker.cpp: missing KUIT context marker line# 361,433,467 (3)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/box/boxtalker.cpp: missing KUIT context marker line# 429,455 (2)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/flickr/flickrwindow.cpp: missing KUIT context marker line# 586,779,814,822 (4)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/pinterest/pwindow.cpp: missing KUIT context marker line# 243,251,283,287,324,382,396,401 (8)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/pinterest/ptalker.cpp: missing KUIT context marker line# 491,517 (2)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/imgur/imgurwindow.cpp: HTML tag 'i' is not advised with KUIT markup line# 235 (1)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/imgur/imgurwindow.cpp: missing KUIT context marker line# 104,114,125,235,243,271,278 (7)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/filecopy/fcexportwindow.cpp: missing KUIT context marker line# 204 (1)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/twitter/twitterwindow.cpp: missing KUIT context marker line# 243,251,283,287,323,386,403,408 (8)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/onedrive/odtalker.cpp: missing KUIT context marker line# 450,475 (2)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/dropbox/dbtalker.cpp: missing KUIT context marker line# 430,456 (2)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/dropbox/dbwindow.cpp: missing KUIT context marker line# 238,245,269,273,311,370,384,389 (8)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/inaturalist/inattalker.cpp: missing KUIT context marker line# 556,558,1927 (3)
      • /mnt/data/Devel/8.x/core/dplugins/generic/webservices/imageshack/imageshackwindow.cpp: missing KUIT context marker line# 228,232,261,319,333,415 (6)
      • /mnt/data/Devel/8.x/core/dplugins/generic/import/dscanner/scandialog.cpp: missing KUIT context marker line# 68,212,225,241,292,300 (6)
      • /mnt/data/Devel/8.x/core/dplugins/bqm/metadata/assigncaptions/assigncaptions.cpp: missing KUIT context marker line# 89,97,104 (3)
      • /mnt/data/Devel/8.x/core/dplugins/bqm/metadata/assigntags/assigntags.cpp: HTML tag 'b' is not advised with KUIT markup line# 78,96,96,96 (4)
      • /mnt/data/Devel/8.x/core/dplugins/bqm/metadata/assigntags/assigntags.cpp: HTML tag 'p' is not advised with KUIT markup line# 78,78,96,96,96 (5)
      • /mnt/data/Devel/8.x/core/dplugins/bqm/metadata/assigntags/assigntags.cpp: missing KUIT context marker line# 88,93,94,95 (4)

      Make the translators' job easier and detect problems in the usage of the i18n() calls. When the fix is not clear, check the Techbase article at http://techbase.kde.org/Development/Tutorials/Localization/i18n_Krazy for more information.

  13. Check for proper include directives [includes]...okay!
  14. Check for inline methods in public classes [inline]...okay!
  15. Check for URLs not using transport encryption [insecurenet]...okay!
  16. Check for normalized SIGNAL and SLOT signatures [normalize]...okay!
  17. Check for assignments to QString::null or QString() [nullstrassign]...okay!
  18. Check for compares to QString::null or QString() [nullstrcompare]...okay!
  19. Check for C++ operators that should be 'const' [operators]...okay!
  20. Check for postfix usage of ++ and -- [postfixop]...okay!
  21. Check for dangerous or inefficient QByteArray usage [qbytearray]...okay!
  22. Check for Qt methods that should be avoided [qmethods]...okay!
  23. Check for classes that should use the 'Q_OBJECT' macro [qobject]...okay!
  24. Check for signals: and slots: [sigsandslots]...okay!
  25. Check for spelling errors [spelling]...OOPS! 6 issues found!
      • /mnt/data/Devel/8.x/core/utilities/geolocation/geoiface/reversegeocoding/rgtagmodel.h: /mnt/data/Devel/8.x/core/utilities/geolocation/geoiface/reversegeocoding/rgtagmodel.h
      • /mnt/data/Devel/8.x/core/utilities/geolocation/geoiface/reversegeocoding/rgtagmodel.h: line# 165[[adress]] (1)
      • /mnt/data/Devel/8.x/core/libs/facesengine/recognition/opencv-dnn/kd_treebase.h: /mnt/data/Devel/8.x/core/libs/facesengine/recognition/opencv-dnn/kd_treebase.h
      • /mnt/data/Devel/8.x/core/libs/facesengine/recognition/opencv-dnn/kd_treebase.h: line# 68[identity identity] (1)
      • /mnt/data/Devel/8.x/core/libs/widgets/itemview/dcategorydrawer.h: /mnt/data/Devel/8.x/core/libs/widgets/itemview/dcategorydrawer.h
      • /mnt/data/Devel/8.x/core/libs/widgets/itemview/dcategorydrawer.h: line# 66[painter painter] (1)

      Spelling errors in comments and strings should be fixed as they may show up later in API documentation, handbooks, etc. Misspelled strings make the translator's job harder. Please use US English.

  26. Check for improperly initialized global static objects [staticobjects]...okay!
  27. Check for strings used improperly or should be i18n. [strings]...okay!
  28. Check for system calls to replace by KDE or Qt equivalents [syscalls]...okay!
  29. Check for typedefs that should be replaced by Qt typedefs [typedefs]...okay!
• For File Type kpartgui
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check for problems with filenames [filenames]...okay!
  3. Check validity of i18n calls [i18ncheckarg]...okay!
  4. Check for URLs not using transport encryption [insecurenet]...okay!
  5. Check for spelling errors [spelling]...okay!
  6. Validates kpartgui files using 'xmllint' [validate]...okay!
• For File Type desktop
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check for problems with filenames [filenames]...okay!
  3. Check for invalid icon names [iconnames]...okay!
  4. Check for URLs not using transport encryption [insecurenet]...OOPS! 6 issues found!
     • /mnt/data/Devel/8.x/core/dplugins/generic/tools/htmlgallery/themes/dateframes/dateframes.desktop: => 354
     • /mnt/data/Devel/8.x/core/dplugins/generic/tools/htmlgallery/themes/dateframes/dateframes.desktop:
     • /mnt/data/Devel/8.x/core/dplugins/generic/tools/htmlgallery/themes/dateframes/dateframes.desktop: => 422
     • /mnt/data/Devel/8.x/core/dplugins/generic/tools/htmlgallery/themes/dateframes/dateframes.desktop:
     • /mnt/data/Devel/8.x/core/dplugins/generic/tools/htmlgallery/themes/dateframes/dateframes.desktop: line# 354,422 (2)

     Prefer URLs using transport encryption. See https://www.volkerkrause.eu/2018/12/08/kde-privacy-finding-insecure-network-connections.html for more information.

  5. Check for spelling errors [spelling]...okay!
  6. Validates desktop files using 'desktop-file-validate' [validate]...okay!
• For File Type svg
  1. Check for problems with filenames [filenames]...okay!
  2. Validate uncompressed SVG files using 'xmllint' [validate]...okay!
• For File Type designer
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check for problems with filenames [filenames]...okay!
  3. Check for files that need to be fixed by 'fixuifiles' [fixuifiles]...okay!
  4. Check validity of i18n calls [i18ncheckarg]...okay!
  5. Check for URLs not using transport encryption [insecurenet]...okay!
  6. Check for spelling errors [spelling]...okay!